-
-
Notifications
You must be signed in to change notification settings - Fork 37.1k
Allow --perf-prof an --perf-basic-prof in NODE_OPTIONS #17571
Copy link
Copy link
Closed
Labels
cliIssues and PRs related to the Node.js command-line interface.Issues and PRs related to the Node.js command-line interface.feature requestIssues requesting new Node.js features.Issues requesting new Node.js features.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.
Description
Activity
Metadata
Metadata
Assignees
Labels
cliIssues and PRs related to the Node.js command-line interface.Issues and PRs related to the Node.js command-line interface.feature requestIssues requesting new Node.js features.Issues requesting new Node.js features.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.
Profiling Node.js programs which spawn another Node.js processes using Linux prof is unnecessarily hard: new processes use executable from the parent process, so it is not possible to add a shell wrapper around Node to add
--perf-profto a subprocess, one has to find all the places where subprocesses are spawned and add the argument there.NODE_OPTIONSis perfect for this task (just run the top-level process with it and all subtree will emit profiling data), but it does not support--perf-profor--perf-basic-profat the moment.Please add it.