http2 compat request can emit 'error'

[ronag]

http/2 compat request object can emit 'error' while http/1 request never emits errors. This can cause problems with servers crashing due with uncaught exception in code that assumes the http/1 behavior.

[mscdex]

http.ClientRequest instances can emit errors, unless you mean http.IncomingMessage ?

[ronag]

I meant http.IncomingMessage

[ronag]

@mscdex ping?

[jasnell]

@ronag ... do you have a test case to reproduce?

Sorry this fell through the cracks because I was watching labels and this one didn't end up getting labeled for some reason...

/cc @nodejs/http2

[ronag]

@jasnell: Http2ServerRequest has an emit('error', ... line

[jasnell]

That particular emit('error', ...) is largely defensively coded and should not ever actually happen. Do you have a test case that demonstrates that it is a problem in practice?

[ronag]

Do you have a test case that demonstrates that it is a problem in practice?

No

That particular emit('error', ...) is largely defensively coded and should not ever actually happen.

Shouldn't it be an assertion in that case?

[Trott]

#24407