Flaky parallel/test-trace-events-fs-sync

[mmarchini]

Test failing occasionally on FreeBSD with different assertion failures:

https://ci.nodejs.org/job/node-test-commit-freebsd/18147/ (#20962)

assert.js:80
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: fs.sync.access:
    at Object.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/parallel/test-trace-events-fs-sync.js:131:10)
    at Module._compile (internal/modules/cjs/loader.js:702:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:713:10)
    at Module.load (internal/modules/cjs/loader.js:612:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:551:12)
    at Function.Module._load (internal/modules/cjs/loader.js:543:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:744:10)
    at startup (internal/bootstrap/node.js:239:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:573:3)

https://ci.nodejs.org/job/node-test-commit-freebsd/18103/ (#21003)

assert.js:80
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: fs.sync.ftruncate:
    at Object.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/parallel/test-trace-events-fs-sync.js:131:10)
    at Module._compile (internal/modules/cjs/loader.js:702:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:713:10)
    at Module.load (internal/modules/cjs/loader.js:612:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:551:12)
    at Function.Module._load (internal/modules/cjs/loader.js:543:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:744:10)
    at startup (internal/bootstrap/node.js:239:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:573:3)

https://ci.nodejs.org/job/node-test-commit-freebsd/18143/ (#21032)

assert.js:80
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: fs.sync.readlink:
    at Object.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/parallel/test-trace-events-fs-sync.js:131:10)
    at Module._compile (internal/modules/cjs/loader.js:702:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:713:10)
    at Module.load (internal/modules/cjs/loader.js:612:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:551:12)
    at Function.Module._load (internal/modules/cjs/loader.js:543:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:744:10)
    at startup (internal/bootstrap/node.js:239:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:573:3)

[Trott]

Seems like this assertion should print the entire proc object rather than just proc.status. This way we could see proc.error, proc.signal, proc.stderr and other things that might be useful to see when the test fails.

[Trott]

Not just FreeBSD. Here it is failing on LinuxONE:

https://ci.nodejs.org/job/node-test-commit-linuxone/1863/nodes=rhel72-s390x/console

03:04:07 not ok 1843 parallel/test-trace-events-fs-sync
03:04:07   ---
03:04:07   duration_ms: 2.122
03:04:07   severity: fail
03:04:07   exitcode: 1
03:04:07   stack: |-
03:04:07     assert.js:80
03:04:07       throw new AssertionError(obj);
03:04:07       ^
03:04:07     
03:04:07     AssertionError [ERR_ASSERTION]: fs.sync.rmdir: 
03:04:07         at Object.<anonymous> (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/parallel/test-trace-events-fs-sync.js:131:10)
03:04:07         at Module._compile (internal/modules/cjs/loader.js:702:30)
03:04:07         at Object.Module._extensions..js (internal/modules/cjs/loader.js:713:10)
03:04:07         at Module.load (internal/modules/cjs/loader.js:612:32)
03:04:07         at tryModuleLoad (internal/modules/cjs/loader.js:551:12)
03:04:07         at Function.Module._load (internal/modules/cjs/loader.js:543:3)
03:04:07         at Function.Module.runMain (internal/modules/cjs/loader.js:744:10)
03:04:07         at startup (internal/bootstrap/node.js:261:19)
03:04:07         at bootstrapNodeJSCore (internal/bootstrap/node.js:595:3)
03:04:07   ...

[Trott]

I updated the title of this to remove on FreeBSD as it appears to be more widespread than that.

[Trott]

Stress test to confirm this is reproducible on FreeBSD:

https://ci.nodejs.org/job/node-stress-single-test/1906/nodes=freebsd11-x64/

[Trott]

stderr is empty and the assertion swallows all the other info that might be useful (status, stdout, signal).

PR to improve output: #21120

[maclover7]

Failure on linuxone:

19:19:16 not ok 1832 parallel/test-trace-events-fs-sync
19:19:16   ---
19:19:16   duration_ms: 1.458
19:19:16   severity: fail
19:19:16   exitcode: 1
19:19:16   stack: |-
19:19:16     assert.js:80
19:19:16       throw new AssertionError(obj);
19:19:16       ^
19:19:16     
19:19:16     AssertionError [ERR_ASSERTION]: fs.sync.fchmod: 
19:19:16         at Object.<anonymous> (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/parallel/test-trace-events-fs-sync.js:131:10)
19:19:16         at Module._compile (internal/modules/cjs/loader.js:702:30)
19:19:16         at Object.Module._extensions..js (internal/modules/cjs/loader.js:713:10)
19:19:16         at Module.load (internal/modules/cjs/loader.js:612:32)
19:19:16         at tryModuleLoad (internal/modules/cjs/loader.js:551:12)
19:19:16         at Function.Module._load (internal/modules/cjs/loader.js:543:3)
19:19:16         at Function.Module.runMain (internal/modules/cjs/loader.js:744:10)
19:19:16         at startup (internal/bootstrap/node.js:261:19)
19:19:16         at bootstrapNodeJSCore (internal/bootstrap/node.js:595:3)
19:19:16   ...

[apapirovski]

Stress test now that we have more useful output: https://ci.nodejs.org/job/node-stress-single-test/1918/