Skip to content

icu build: use genccode -o on non-windows platforms #21695

Description

@srl295
  • Platform: all
  • Subsystem: deps

some (all?) non-windows platforms we build on, could support ICU's .dat-to-.obj file conversion via assembler, but right now it's only enabled on windows. Others get:

generating C code for /Users/srl/src/node/out/Release/obj/gen/icudt62.dat
  CC(target) /Users/srl/src/node/out/Release/obj.target/icudata/gen/icudt62_dat.o

…and yes, that's a hefty .c file. i found/refound this when @bnoordhuis started re-implementing what ICU aready supports.

I think a small whitelist of compilers/platforms might suffice: gcc/linux, gcc/aix, gcc/mac, gcc/mingw, gcc/solaris ( Hmm, I guess that's just one compiler)

On windows, we use the -o option which outputs a .obj file directly with no intermediate files.

advantage would be to speed up the build a little bit, probably reduce max memory/swap footprint.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

buildIssues and PRs related to Node.js builds or CI infrastructure.i18n-apiIssues and PRs related to Node.js internationalization support.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions