-
-
Notifications
You must be signed in to change notification settings - Fork 37.4k
Win32 method name conventions? #2335
Copy link
Copy link
Closed
Labels
questionIssues asking questions about Node.js.Issues asking questions about Node.js.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
Description
Activity
Metadata
Metadata
Assignees
Labels
questionIssues asking questions about Node.js.Issues asking questions about Node.js.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
Looking through the Windows-specific code, I see lots of instances of
*W(likeGetVersionW) methods called explicitly, which forces wide characters. Typically I'd expect use use of undecorated names likeGetVersion, which lets the compiler configure for or against wide character support (and is future proof!)See: https://github.com/nodejs/io.js/blob/master/src/node_os.cc#L96
Is there any reason why the code is written this way?
There was a commit from @piscisaureus that describes a change from
GetVersionAtoGetVersionW-- should calls like this be changed again to justGetVersion?