-
-
Notifications
You must be signed in to change notification settings - Fork 35.7k
tls: TLSSocket options not initialized #2394
Copy link
Copy link
Closed
Labels
good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.tlsIssues and PRs related to the tls subsystem.Issues and PRs related to the tls subsystem.
Metadata
Metadata
Assignees
Labels
good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.tlsIssues and PRs related to the tls subsystem.Issues and PRs related to the tls subsystem.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Per: nodejs/node-v0.x-archive#7218 by @adammw
This was a PR originally opened against joyent/node but never landed. On the
TLSSocket constructor, the options parameter is not verified to be undefined and
the code assume's it's not. The PR was originally reviewed by @indutny but had
some issues that were never fully resolved. The PR would need to be reopened
here and updated before it can land.