-
-
Notifications
You must be signed in to change notification settings - Fork 37.4k
Update installer resources #2418
Copy link
Copy link
Closed
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.
Description
Activity
Metadata
Metadata
Assignees
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.
After #2367 has landed, a few things have to be fixed on the Windows and OS X installers:
Regarding the Windows installer, you can remove the following lines (linking of iojs.exe to nodejs.exe):
On OS X, these lines have to be changed:
io.js icon on the installer must be replaced as well:
https://github.com/cjihrig/node-1/blob/rename/tools/msvs/msi/product.wxs#L28
Same for the OS X installer:
https://github.com/cjihrig/node-1/blob/rename/tools/osx-pkg.pmdoc/index.xml.tmpl#L24