'crypto' is broken with '--throw-deprecation'

[comods]

• Version: 11.6.0
• Platform: Windows 7 64bit
• Subsystem: crypto

module 'crypto' is broken as it doesn't work at all with '--throw-deprecation'.

C:\>node --experimental-modules --throw-deprecation test.mjs

//test.mjs
import 'crypto';

My understanding is that 'crypto' is not deprecated, only crypto.DEFAULT_ENCODING is. So crypto needs to still work with --throw-deprecation! If 'crypto' in its entirity is deprecated, then what is the migration path for crypto.randomBytes?

[cjihrig]

I believe this is fixed on master by #23222, and will be released in Node 12.0.0.

[comods]

Could the following test be added to every internal module?

For each module, have a test that runs on 'node --throw-deprecation' and imports the module. If any part of the module is not deprecated, then just importing should never throw an error. Only accessing the deprecated parts of the module should.

If the entire module is deprecated, this unit test would be marked as failed until manually removed for just this module.

[cjihrig]

Closing as resolved. If you want to send a PR adding a test, feel free.