V8 build config

[gengjiawen]

Issue one

This file no longer exists. Maybe replaced with this file special-case.h ?

node/deps/v8/BUILD.gn

Line 2731 in 2dcc366

"src/regexp/regexp-special-case.h",

looks like an issue from upstream.
https://github.com/v8/v8/blob/0d07272a7fac4d5e84c9aa5dd96e6dbce6e9d673/BUILD.gn#L2749

cc @nodejs/v8 @targos @hashseed

Issue two

The file has moved to src/init

node/tools/v8_gypfiles/v8_external_snapshot.gypi

Line 39 in 3b5773f

'<(V8_ROOT)/src/setup-isolate-deserialize.cc',

cc @nodejs/gyp

[ryzokuken]

@gengjiawen I think I'm qualified to answer this.

1. While this might be a legitimate issue, we do not use or own the BUILD.gn files since they're a part of the V8 project. If you think it's problematic that they include that file, please feel free to create an issue upstream at https://bugs.chromium.org/p/v8/issues/entry.

2. The gyp files we do infact own, and this might have slipped through one of our updates. That said, this neither breaks nor causes any other problems with the build, and I'd rather not make any changes to our gypfiles unless they break something.

[gengjiawen]

@refack Is v8_external_snapshot.gypi still in use ?

[ryzokuken]

@gengjiawen @refack seems to be on a break. And yes, it's still used. I'll make a PR to fix it now.

[ryzokuken]

I'm sorry, literally the first line of the file says # Keeping this separate since Node.js does use it. Let me try to build after removing the file, see if that works.

[gengjiawen]

Looks like GN is improving on this

https://bugs.chromium.org/p/chromium/issues/detail?id=991547

#29694 (comment)