Skip to content

Lack of consistency in maxRequestPerSocket #40190

Description

@mcollina

Version

v16.10.0

Platform

all

Subsystem

http

What steps will reproduce the bug?

server.maxRequestPerSocket as defined in https://nodejs.org/api/http.html#http_server_maxrequestspersocket uses null for "no limit". However in most other places of http we use 0 to identify no limit.

server.maxRequestPerSocket should use 0 as well as null (to not break anybody), or just consider it a bugfix and remove null support.

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

No response

What do you see instead?

No response

Additional information

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    httpIssues and PRs related to the http subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions