Return value of url.parse() in nodejs version 16 and 17 is different from old version.

[LvChengbin]

Version

16.14.0

Platform

No response

Subsystem

No response

What steps will reproduce the bug?

Run the following code with nodejs v15 and v16 gets different output.

const { parse } = require( 'url' );
parse( '//foo@bar' );

Output with nodejs 14:

{
    protocol: null,
    slashes: null,
    auth: null,
    host: null,
    port: null,
    hostname: null,
    hash: null,
    search: null,
    query: null,
    pathname: "//foo@bar",
    path: "//foo@bar",
    href: "//foo@bar"
}

Output with nodejs 16:

{
    protocol: null,
    slashes: true,
    auth: "foo",
    host: "bar",
    port: null,
    hostname: "bar",
    hash: null,
    search: null,
    query: null,
    pathname: null,
    path: null,
    href: "//foo@bar"
}

https://runkit.com/62249077dc641400085658be/6224907756c9c7000882de7a

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

No response

What do you see instead?

I am not sure if it's a bug or not, but it's changed and cannot be found from documentation.
https://nodejs.org/dist/latest-v16.x/docs/api/url.html#urlparseurlstring-parsequerystring-slashesdenotehost

Additional information

No response

[Trott]

This was a bug fix in #41031.

In 14.x, adding a hash to the path changed the behavior which seemed surprising to put it mildly.

> url.parse('//foo@bar/what')
Url {
  protocol: null,
  slashes: null,
  auth: null,
  host: null,
  port: null,
  hostname: null,
  hash: null,
  search: null,
  query: null,
  pathname: '//foo@bar/what',
  path: '//foo@bar/what',
  href: '//foo@bar/what'
}
> url.parse('//foo@bar/what#hey')
Url {
  protocol: null,
  slashes: true,
  auth: 'foo',
  host: 'bar',
  port: null,
  hostname: 'bar',
  hash: '#hey',
  search: null,
  query: null,
  pathname: '/what',
  path: '/what',
  href: '//foo@bar/what#hey'
}
>

In 16.x, the behavior is consistent with or without the hash.

[Trott]

I'm going to close this, but feel free to re-open or comment if there's more to discuss.