-
-
Notifications
You must be signed in to change notification settings - Fork 37.1k
Refactor util._extend to Object.assign #4838
Copy link
Copy link
Closed
Labels
duplicateIssues and PRs that are duplicates of other issues or PRs.Issues and PRs that are duplicates of other issues or PRs.utilIssues and PRs related to the built-in util module.Issues and PRs related to the built-in util module.
Description
Activity
Metadata
Metadata
Assignees
Labels
duplicateIssues and PRs that are duplicates of other issues or PRs.Issues and PRs that are duplicates of other issues or PRs.utilIssues and PRs related to the built-in util module.Issues and PRs related to the built-in util module.
Hey, I figured we can change
util._extendtoObject.assignin various places and replaceutil._extenditself withObject.assign.As this is a small (but breaking) change for edge cases I figured I'd bring it up for discussion first.
The only difference is that
assigncopies symbols as well - I don't think it'll cause any issues.