Example error: https://ci.nodejs.org/job/node-test-commit-v8-linux/5468/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/console
I wonder if we actually need to check the output of perf script - IIUC we are just checking that linux perf can produce maps for both interpreted and compiled functions. In this case simply checking the perf map should be enough (as long as the mappings are produced, they should appear). Checking the output of perf script may not be robust enough unless we tweak the how the functions are sampled very carefully (but it can still depend a lot on the state of the machine).
Example error: https://ci.nodejs.org/job/node-test-commit-v8-linux/5468/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/console
I wonder if we actually need to check the output of
perf script- IIUC we are just checking that linux perf can produce maps for both interpreted and compiled functions. In this case simply checking the perf map should be enough (as long as the mappings are produced, they should appear). Checking the output ofperf scriptmay not be robust enough unless we tweak the how the functions are sampled very carefully (but it can still depend a lot on the state of the machine).