-
-
Notifications
You must be signed in to change notification settings - Fork 37.1k
linter fails after running make test-addons #5424
Copy link
Copy link
Closed
Labels
testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.toolsIssues and PRs related to the tools directory.Issues and PRs related to the tools directory.
Description
Activity
Metadata
Metadata
Assignees
Labels
testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.toolsIssues and PRs related to the tools directory.Issues and PRs related to the tools directory.
The git ignored artifacts created by
make test-addonsare not passing the linter after the upgrade to eslint v2This is blocking #5372 landing on LTS, it is also at the very least annoying on master.
I have a naive fix by adding
test/addons/0*to the.eslintignore. PR incoming.Should the temporary artifacts of the addons test be living in the test dir?