Stalled Issue action is not working

[avivkeller]

I noticed that #40354 has been labelled stalled for a while. While it's received activity in the past few hours, before that, there was no activity for 2 months (since #40354 (comment)).

Another case is #51567.

The action is set up to close issues after 30 days of no activity after being labelled stale, yet that didn't occur?

[Trott]

Another case is #51567.

If I'm not mistaken, #51567 does not (and has never had) a stalled label and has been merged. What makes you say it shows that the Action is not working? Did you mean a different PR perhaps?

[avivkeller]

If I'm not mistaken, #51567 does not (and has never had) a stalled label and has been merged. What makes you say it shows that the Action is not working? Did you mean a different PR perhaps?

I was probably referring to a different issue/PR, but I can't remember which one, I opened this issue 7 months ago 😅

However, if you look at the list of currently open stalled issues/PRs (https://github.com/nodejs/node/pulls?q=is%3Apr+is%3Aopen+label%3Astalled+), you'll see that a large portion of them have been stalled for more than the set 30 days.

For example, #29554 has been stalled for 5 years.

[Trott]

I believe it is working as designed because we have remove-stale-when-updated set to false. So the stalled label was applied, but someone left a comment within 30 days, and so it won't be closed until the stalled label is removed and reapplied. See the Actions output below.

[#40354] This pull request is already stale
  [#40354] Checking for label on this pull request
  [#40354] Pull request marked stale on: 2024-05-11T18:02:44Z
  [#40354] Checking for comments on pull request since: 2024-05-11T18:02:44Z
  [#40354] Comments that are not the stale comment or another bot: 5
  [#40354] Pull request has been commented on: true
  [#40354] Days before pull request close: 30
  [#40354] The option remove-stale-when-updated (​[https://github.com/actions/stale#remove-stale-when-updated​)](https://github.com/actions/stale#remove-stale-when-updated%E2%80%8B)) is: false
  [#40354] The stale label should be removed if all conditions met
  [#40354] Pull request has been updated since it was marked stale: true
  [#40354] Pull request has been updated in the last 30 days: true
  [#40354] Stale pull request is not old enough to close yet (hasComments? true, hasUpdate? true)
  [#40354] 2 operations consumed for this pull request

Workaround for now is to remove and reapply the stalled label.

I believe the proper fix is to let remove-stale-when-updated be its default value of true. I'll open a PR for that right now.