Skip to content

Streams: writableStreamDefaultControllerGetChunkSize undefined strategy case slightly broken #56014

Description

@domenic

Version

This is based on source inspection

Platform

This is based on source inspection

Subsystem

web streams

What steps will reproduce the bug?

See whatwg/streams#1333.

Per

function writableStreamDefaultControllerGetChunkSize(controller, chunk) {
, Node has the same bug as the reference implementation did: it catches the exception caused by trying to call undefined as a function, and then attempts to error the stream with it.

I don't believe this is observable since the stream is already erroring so the "TypeError: cannot call undefined" will not actually be exposed to the web developer.

However, it's probably best to fix this.

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior? Why is that the expected behavior?

Check for undefined before calling the function

What do you see instead?

You're catching it

Additional information

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    web streamsIssues and PRs related to the Web Streams API.web-standardsIssues and PRs related to web-platform APIs and standards compliance.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions