Skip to content

parallel/test-inspector-dom-storage writes to current working directory #62646

Description

@richardlau

parallel/test-inspector-dom-storage (added by #61139) is writing localstorage.db to the current working directory. This is counter to the expectation that tests write to a temp directory (e.g. via common.tmpdir) that gets cleaned up afterwards.

e.g.

$ pwd
/tmp
$ ls -al
total 0
drwxrwxrwt. 1 root root  6 Apr  9 13:43 .
drwxr-xr-x. 1 root root 29 Apr  9 11:56 ..
$ ~/sandbox/github/node/out/Release/node ~/sandbox/github/node/test/parallel/test-inspector-dom-storage.js
NOTE: The test started as a child_process using these flags: [
  '--inspect=0',
  '--experimental-storage-inspection',
  '--localstorage-file=./localstorage.db'
] And these environment variables: {} Use NODE_SKIP_FLAG_CHECK to run the test with the original flags.
Debugger listening on ws://127.0.0.1:39585/a72ca654-160b-47a7-a4e5-b04ac1bcd0b9
For help, see: https://nodejs.org/en/docs/inspector
$ ls -al
total 16
drwxrwxrwt. 1 root root    29 Apr  9 13:48 .
drwxr-xr-x. 1 root root    29 Apr  9 11:56 ..
-rw-r--r--. 1 rlau rlau 16384 Apr  9 13:48 localstorage.db
$

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions