-
-
Notifications
You must be signed in to change notification settings - Fork 38.4k
quic: Documentation on async write on QuicStreamΒ #63305
Copy link
Copy link
Closed
Labels
never-staleIssues and PRs exempt from automated stale handling.Issues and PRs exempt from automated stale handling.quicIssues and PRs related to the QUIC transport implementation.Issues and PRs related to the QUIC transport implementation.
Description
Activity
Metadata
Metadata
Assignees
Labels
never-staleIssues and PRs exempt from automated stale handling.Issues and PRs exempt from automated stale handling.quicIssues and PRs related to the QUIC transport implementation.Issues and PRs related to the QUIC transport implementation.
The current documentation says:
The async variant behaves currently like a push source in
strictmode see https://github.com/WinterTC55/iter-streams/blob/main/docs/DESIGN.md#4-push-stream .So it rejects if the flow control buffer is full.
Maybe this is the desired behavior.
I think this should be stated in documentation. Together with an example, how one want to check if the buffer is full.
Alternatively, a behavior, such as
block,may be considered as an option.That is only a tiny issue, I was wondering.
@jasnell