Why path.basename behaves differently by platform?

[sttk]

• Version: 0.10, 0.11, 4, 5, 6
• Platform: darwin, linux, win32
• Subsystem: path

1. When path is non-string

   [darwin] path.basename(null);  // => TypeError
   [linux]  path.basename(null);  // => 'null'
   [win32]  path.basename(null);  // => 'null'
   
   [darwin] path.basename(123);  // => TypeError
   [linux]  path.basename(123);  // => '123'
   [win32]  path.basename(123);  // => '123'

2. When ext matches path's tail and contains a path separator.

   [darwin] path.basename('aaa/bbb', '/bbb');   // => ''
   [linux]  path.basename('aaa/bbb', '/bbb');   // => ''
   [win32]  path.basename('aaa/bbb', '/bbb');   // => 'bbb'
   [win32]  path.basename('aaa\\bbb', '\\bbb'); // => 'bbb'
   
   [darwin] path.basename('aaa/bbb', 'a/bbb');   // => ''
   [linux]  path.basename('aaa/bbb', 'a/bbb');   // => ''
   [win32]  path.basename('aaa/bbb', 'a/bbb');   // => 'bbb'
   [win32]  path.basename('aaa\\bbb', 'a\\bbb'); // => 'bbb'

   FYI, basename command behaves as follows (I checked on darwin and linux):

   $ basename aaa/bbb bbb
   bbb
   $ basename aaa/bbb /bbb
   bbb
   $ basename aaa/bbb a/bbb
   bbb
   

[addaleax]

I think 1. can be considered fixed in v6.0.0 in the sense that those always throw a TypeError now. 2. is certainly a bit more interesting, although I can’t really tell what the expected behaviour in such a case might be.

[jasnell]

/cc @mscdex

[sttk]

@addaleax

I think 1. can be considered fixed in v6.0.0 in the sense that those always throw a TypeError now.

I've checked on appveyor (windows) and travis (linux) that 1. was fixed in v6.

[sttk]

I'm sorry.
2. was also fixed in v5 that node returns '' on all platform.
This problem is not by platform but by version.

[mscdex]

No, the second case is definitely an unintended regression/bug. I am working on a fix.