Windows build failed for v6.3.0

[ayoubserti]

• Version: v6.3.0
• Platform: Windows VS2013
• Subsystem: Windows7

I can't build nodejs v6.3.0 on Windows 7 VS2013.
i got the error:

> vcbuild.bat nobuild nosign

Looking for Visual Studio 2015
Looking for Visual Studio 2013
Found Visual Studio 2013
configure  --dest-cpu=x86 --tag=
creating  icu_config.gypi
* Using ICU in deps/icu-small
creating  icu_config.gypi
{ 'target_defaults': { 'cflags': [],
                       'default_configuration': 'Release',
                       'defines': [],
                       'include_dirs': [],
                       'libraries': []},
  'variables': { 'asan': 0,
                 'debug_devtools': 'node',
                 'host_arch': 'x64',
                 'icu_data_file': 'icudt57l.dat',
                 'icu_data_in': '..\\..\\deps/icu-small\\source/data/in\\icudt57l.dat',
                 'icu_endianness': 'l',
                 'icu_gyp_path': 'tools/icu/icu-generic.gyp',
                 'icu_locales': 'en,root',
                 'icu_path': 'deps/icu-small',
                 'icu_small': 'true',
                 'icu_ver_major': '57',
                 'node_byteorder': 'little',
                 'node_enable_v8_vtunejit': 'false',
                 'node_install_npm': 'true',
                 'node_module_version': 48,
                 'node_no_browser_globals': 'false',
                 'node_prefix': '/usr/local',
                 'node_release_urlbase': '',
                 'node_shared': 'false',
                 'node_shared_cares': 'false',
                 'node_shared_http_parser': 'false',
                 'node_shared_libuv': 'false',
                 'node_shared_openssl': 'false',
                 'node_shared_zlib': 'false',
                 'node_tag': '',
                 'node_use_bundled_v8': 'true',
                 'node_use_dtrace': 'false',
                 'node_use_etw': 'true',
                 'node_use_lttng': 'false',
                 'node_use_openssl': 'true',
                 'node_use_perfctr': 'true',
                 'node_use_v8_platform': 'true',
                 'openssl_fips': '',
                 'openssl_no_asm': 0,
                 'target_arch': 'ia32',
                 'v8_enable_gdbjit': 0,
                 'v8_enable_i18n_support': 1,
                 'v8_inspector': 'true',
                 'v8_no_strict_aliasing': 1,
                 'v8_optimized_debug': 0,
                 'v8_random_seed': 0,
                 'v8_use_snapshot': 'true',
                 'want_separate_host_toolset': 1}}
creating  config.gypi
creating  config.mk
Warning: Missing input files:
deps\v8_inspector\platform\v8_inspector\MuteConsoleScope.h
deps\v8_inspector\platform\v8_inspector\public\V8EventListenerInfo.h
deps\v8_inspector\platform\v8_inspector\<(blink_platform_output_dir\v8_inspector\DebuggerScript.h
deps\v8_inspector\platform\v8_inspector\IgnoreExceptionsScope.h
deps\v8_inspector\platform\v8_inspector\public\V8HeapProfilerAgent.h
deps\cares\src\ares_rules.h
deps\v8_inspector\platform\v8_inspector\<(blink_platform_output_dir\v8_inspector\InjectedScriptSource.h
src\inspector-agent.h
Project files generated.

some files are missing within v6.x branch

[mscdex]

/cc @ofrobots

[ofrobots]

Interesting that things work in the CI. /cc @eugeneo.

[ayoubserti]

Some files was removed from this branch and the .gyp project keep including those files:

e.g: cares.gyp

     'src/ares_rules.h',

[richardlau]

deps\v8_inspector\platform\v8_inspector\<(blink_platform_output_dir\v8_inspector\DebuggerScript.h
deps\v8_inspector\platform\v8_inspector\<(blink_platform_output_dir\v8_inspector\InjectedScriptSource.h

These two are because deps/v8_inspector/platform/v8_inspector/v8_inspector.gyp is missing the closing ) for <(blink_platform_output_dir):

        '<(blink_platform_output_dir/v8_inspector/DebuggerScript.h',
        '<(blink_platform_output_dir/v8_inspector/InjectedScriptSource.h',

[ayoubserti]

hello,

when compiling with VS2013, the project node_i18n can't compile:

src\node_i18n.cc(86): error C2065: 'UIDNA_DEFAULT' : undeclared identifier
8>src\node_i18n.cc(87): error C2065: 'UIDNA_NONTRANSITIONAL_TO_UNICODE' : undeclared identifier
8>src\node_i18n.cc(88): error C2065: 'UIDNA' : undeclared identifier
8>src\node_i18n.cc(88): error C2065: 'uidna' : undeclared identifier
8>src\node_i18n.cc(88): error C3861: 'uidna_openUTS46_57': identifier not found
8>src\node_i18n.cc(91): error C2065: 'UIDNAInfo' : undeclared identifier
8>src\node_i18n.cc(91): error C2146: syntax error : missing ';' before identifier 'info'
8>src\node_i18n.cc(91): error C2065: 'info' : undeclared identifier
8>src\node_i18n.cc(91): error C2065: 'UIDNA_INFO_INITIALIZER' : undeclared identifier
8>src\node_i18n.cc(93): error C2065: 'uidna' : undeclared identifier
8>src\node_i18n.cc(96): error C2065: 'info' : undeclared identifier
8>src\node_i18n.cc(93): error C3861: 'uidna_nameToUnicodeUTF8_57': identifier not found
8>src\node_i18n.cc(102): error C2065: 'uidna' : undeclared identifier
8>src\node_i18n.cc(105): error C2065: 'info' : undeclared identifier
8>src\node_i18n.cc(102): error C3861: 'uidna_nameToUnicodeUTF8_57': identifier not found
8>src\node_i18n.cc(112): error C2065: 'uidna' : undeclared identifier
8>src\node_i18n.cc(112): error C3861: 'uidna_close_57': identifier not found
8>src\node_i18n.cc(120): error C2065: 'UIDNA_DEFAULT' : undeclared identifier
8>src\node_i18n.cc(121): error C2065: 'UIDNA_NONTRANSITIONAL_TO_ASCII' : undeclared identifier
8>src\node_i18n.cc(122): error C2065: 'UIDNA' : undeclared identifier
8>src\node_i18n.cc(122): error C2065: 'uidna' : undeclared identifier
8>src\node_i18n.cc(122): error C3861: 'uidna_openUTS46_57': identifier not found
8>src\node_i18n.cc(125): error C2065: 'UIDNAInfo' : undeclared identifier
8>src\node_i18n.cc(125): error C2146: syntax error : missing ';' before identifier 'info'
8>src\node_i18n.cc(125): error C2065: 'info' : undeclared identifier
8>src\node_i18n.cc(125): error C2065: 'UIDNA_INFO_INITIALIZER' : undeclared identifier
8>src\node_i18n.cc(127): error C2065: 'uidna' : undeclared identifier
8>src\node_i18n.cc(130): error C2065: 'info' : undeclared identifier
8>src\node_i18n.cc(127): error C3861: 'uidna_nameToASCII_UTF8_57': identifier not found
8>src\node_i18n.cc(136): error C2065: 'uidna' : undeclared identifier
8>src\node_i18n.cc(139): error C2065: 'info' : undeclared identifier
8>src\node_i18n.cc(136): error C3861: 'uidna_nameToASCII_UTF8_57': identifier not found
8>src\node_i18n.cc(146): error C2065: 'uidna' : undeclared identifier
8>src\node_i18n.cc(146): error C3861: 'uidna_close_57': identifier not found

[joaocgreis]

@ayoubserti you should compile with

> vcbuild.bat nosign

If you use nobuild, it will not build anything (it's useful for when you have node already built and just want to run the tests, like vcbuild nosign noprojgen nobuild test). The warning about missing files is normal, those files are generated as part of the build process before they are needed, but gyp doesn't know that and prints the warning.

Please make sure you have a clean tree before you try to compile again. Delete the folder and unzip again, or if you're using git:

git clean -fdx
git reset --hard

[ayoubserti]

@joaocgreis I know nobuild will generate VS projects and solution without building.

after git reset --hard i regenerate project and i got:

[joaocgreis]

I can reproduce, node doesn't build from Visual Studio IDE.

This happens exactly because of what @richardlau pointed out: Besides listing those two entries as "missing input files", the generated .vcxproj is invalid and the VS IDE can't open it. Somehow, msbuild is able to work as expected, but not the IDE.

@ofrobots Should we float a patch here or should we try to submit it upstream?

@ayoubserti for now, it seems that building from the command line is the only way.

[ofrobots]

@joaocgreis we are already working on bringing in a new version of v8_inspector dependency that is going to include a fix for this problem.