Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
nodejs
/
node
Public
Uh oh!
There was an error while loading.
Please reload this page
.
Notifications
You must be signed in to change notification settings
Fork
37.2k
Star
122k
Code
Issues
630
Pull requests
546
Actions
Projects
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Projects
Security and quality
Insights
[v6.x backport] tools: non-Ascii linter for /lib only
- #19493
#19493
Closed
SirR4T
wants to merge 26 commits into
nodejs:v6.x-staging
nodejs/node:v6.x-staging
from
SirR4T:backport-18043-to-v6.x
SirR4T/node:backport-18043-to-v6.x
Copy head branch name to clipboard
Conversation
Commits
26
(26)
Checks
Files changed
Closed
[v6.x backport] tools: non-Ascii linter for /lib only
#19493
SirR4T
wants to merge 26 commits into
nodejs:v6.x-staging
nodejs/node:v6.x-staging
from
SirR4T:backport-18043-to-v6.x
SirR4T/node:backport-18043-to-v6.x
Copy head branch name to clipboard
Commits
Commits on Mar 28, 2018
test: fix spelling in test case comments
Show description for 1196355
tniessen
authored and
MylesBorins
committed
1196355
View commit details
Copy full SHA for 1196355
Browse repository at this point
fs: fix `createReadStream(…, {end: n})` for non-seekable fds
Show description for 377fe93
addaleax
authored and
MylesBorins
committed
377fe93
View commit details
Copy full SHA for 377fe93
Browse repository at this point
test: remove mark flaky for moved test
Show description for 96c8781
BethGriggs
authored and
MylesBorins
committed
96c8781
View commit details
Copy full SHA for 96c8781
Browse repository at this point
crypto: reuse variable instead of reevaluation
Show description for 1e1478a
tniessen
authored and
MylesBorins
committed
1e1478a
View commit details
Copy full SHA for 1e1478a
Browse repository at this point
test: make common.mustNotCall show file:linenumber
Show description for 7d0cdf2
lance
authored and
MylesBorins
committed
7d0cdf2
View commit details
Copy full SHA for 7d0cdf2
Browse repository at this point
test: remove n-api intermediate files
Show description for 630a306
Gabriel Schulhof
authored and
MylesBorins
committed
630a306
View commit details
Copy full SHA for 630a306
Browse repository at this point
test: remove orphaned entries from status
Show description for bf88a08
kfarnung
authored and
MylesBorins
committed
bf88a08
View commit details
Copy full SHA for bf88a08
Browse repository at this point
http: free the parser before emitting 'upgrade'
Show description for 94a954a
lpinca
authored and
MylesBorins
committed
94a954a
View commit details
Copy full SHA for 94a954a
Browse repository at this point
stream: simplify `src._readableState` to `state`
Show description for 0f593be
陈刚
authored and
MylesBorins
committed
0f593be
View commit details
Copy full SHA for 0f593be
Browse repository at this point
doc: reorder section on updating PR branch
Show description for 1bc9c4e
ofrobots
authored and
MylesBorins
committed
1bc9c4e
View commit details
Copy full SHA for 1bc9c4e
Browse repository at this point
doc: add Gibson Fahnestock to TSC
Show description for dd6bcc6
Trott
authored and
MylesBorins
committed
dd6bcc6
View commit details
Copy full SHA for dd6bcc6
Browse repository at this point
doc: move Brian White to TSC Emeriti list
Show description for 83e5f41
Trott
authored and
MylesBorins
committed
83e5f41
View commit details
Copy full SHA for 83e5f41
Browse repository at this point
doc: streamline README intro
Show description for 9c4f6f5
Trott
authored and
MylesBorins
committed
9c4f6f5
View commit details
Copy full SHA for 9c4f6f5
Browse repository at this point
test: verify the shell option works properly on execFile
Show description for de312a3
jvelezpo
authored and
MylesBorins
committed
de312a3
View commit details
Copy full SHA for de312a3
Browse repository at this point
build: allow x86_64 as a dest_cpu alias for x64
Show description for 67e9498
rvagg
authored and
MylesBorins
committed
67e9498
View commit details
Copy full SHA for 67e9498
Browse repository at this point
net: remove redundant code from _writeGeneric()
Show description for 5dade66
lpinca
authored and
MylesBorins
committed
5dade66
View commit details
Copy full SHA for 5dade66
Browse repository at this point
test: update references to archived repository
Show description for ebd9a18
tniessen
authored and
MylesBorins
committed
ebd9a18
View commit details
Copy full SHA for ebd9a18
Browse repository at this point
readline: update references to archived repository
Show description for 096e4c6
tniessen
authored and
MylesBorins
committed
096e4c6
View commit details
Copy full SHA for 096e4c6
Browse repository at this point
build: refine static and shared lib build
Show description for ddcfffb
yhwang
authored and
MylesBorins
committed
ddcfffb
View commit details
Copy full SHA for ddcfffb
Browse repository at this point
stream: remove unreachable code
Show description for eeaecce
lpinca
authored and
MylesBorins
committed
eeaecce
View commit details
Copy full SHA for eeaecce
Browse repository at this point
test: use correct size in test-stream-buffer-list
Show description for e22a645
lpinca
authored and
MylesBorins
committed
e22a645
View commit details
Copy full SHA for e22a645
Browse repository at this point
doc: linkify missing types
Show description for 4444802
vsemozhetbyt
authored and
MylesBorins
committed
4444802
View commit details
Copy full SHA for 4444802
Browse repository at this point
win, build: fix without-intl option
Show description for a47fda4
bzoz
authored and
MylesBorins
committed
a47fda4
View commit details
Copy full SHA for a47fda4
Browse repository at this point
win, build: fix intl-none option
Show description for d4d4cec
poiru
authored and
MylesBorins
committed
d4d4cec
View commit details
Copy full SHA for d4d4cec
Browse repository at this point
process: fix reading zero-length env vars on win32
Show description for 0a4c79b
addaleax
authored and
MylesBorins
committed
0a4c79b
View commit details
Copy full SHA for 0a4c79b
Browse repository at this point
Commits on Mar 29, 2018
tools: non-Ascii linter for /lib only
Show description for bc22bf0
Sarat Addepalli
committed
bc22bf0
View commit details
Copy full SHA for bc22bf0
Browse repository at this point
You can’t perform that action at this time.