Skip to content

process: properly close file descriptor on exit - #24972

Closed
BridgeAR wants to merge 1 commit into
nodejs:masterfrom
BridgeAR:fix-async-warnings
Closed

process: properly close file descriptor on exit#24972
BridgeAR wants to merge 1 commit into
nodejs:masterfrom
BridgeAR:fix-async-warnings

Conversation

@BridgeAR

Copy link
Copy Markdown
Member

This makes sure the file descriptor is closed syncronously on exit
instead of using the asyncronous version which should not be used
on exit.

This is pulled out from #24965 as suggested by @addaleax.

Refs: https://github.com/nodejs/node/pull/24965/files#r240770314

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This makes sure the file descriptor is closed syncronously on exit
instead of using the asyncronous version which should not be used
on exit.
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Dec 11, 2018
@BridgeAR

ghost commented Dec 12, 2018

Copy link
Copy Markdown
Member Author

@BridgeAR BridgeAR added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 12, 2018
@Trott

ghost commented Dec 14, 2018

Copy link
Copy Markdown
Member

@Trott

ghost commented Dec 14, 2018

Copy link
Copy Markdown
Member

AIX failures in CI were one known issue (#24921) that @gireeshpunathil is investigated but is currently awaiting access to the relevant AIX host (nodejs/build#1637), and one issue that I don't think is new but hasn't been reported to track it so I opened an issue (#25029).

Will open a PR to mark as flaky if they persist. In the meantime....

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19503/ ✔️

@Trott

ghost commented Dec 14, 2018

Copy link
Copy Markdown
Member

Landed in 80ab537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. process Issues and PRs related to the process subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants