Skip to content

http2: allow passing FileHandle to respondWithFD#29876

Closed
addaleax wants to merge 5 commits into
nodejs:masterfrom
addaleax:http2-filehandle
Closed

http2: allow passing FileHandle to respondWithFD#29876
addaleax wants to merge 5 commits into
nodejs:masterfrom
addaleax:http2-filehandle

Conversation

@addaleax
Copy link
Copy Markdown
Member

@addaleax addaleax commented Oct 7, 2019

This seems to make sense if we want to promote the use
of fs.promises, although it’s not strictly necessary.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system. http2 Issues or PRs related to the http2 subsystem. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants