Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
Uh oh!
There was an error while loading.
Please reload this page
.
nodejs
/
node
Public
Uh oh!
There was an error while loading.
Please reload this page
.
Notifications
You must be signed in to change notification settings
Fork
37k
Star
122k
Code
Issues
633
Pull requests
563
Actions
Projects
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Projects
Security and quality
Insights
stream: fix handling generators in Readable.from
- #32844
#32844
Closed
vadzim
wants to merge 11 commits into
nodejs:master
nodejs/node:master
from
vadzim:FixHandlingGeneratorsInReadableFrom
vadzim/node:FixHandlingGeneratorsInReadableFrom
Copy head branch name to clipboard
Conversation
Commits
11
(11)
Checks
Files changed
Closed
stream: fix handling generators in Readable.from
#32844
vadzim
wants to merge 11 commits into
nodejs:master
nodejs/node:master
from
vadzim:FixHandlingGeneratorsInReadableFrom
vadzim/node:FixHandlingGeneratorsInReadableFrom
Copy head branch name to clipboard
Commits
Commits on Apr 15, 2020
stream: close iterator in Readable.from
Show description for 2fa5848
vadzim
committed
2fa5848
View commit details
Copy full SHA for 2fa5848
Browse repository at this point
fixup: explicit `yielded` event in closeStreamWhileNextIsPending
vadzim
committed
980a7c8
View commit details
Copy full SHA for 980a7c8
Browse repository at this point
fixup: test fot iterator closing after null has been yielded
vadzim
committed
b772927
View commit details
Copy full SHA for b772927
Browse repository at this point
fixup: escape unhandled rejected promise
vadzim
committed
57bb126
View commit details
Copy full SHA for 57bb126
Browse repository at this point
fixup: test for closing iterator on yielded null
Show description for 8a2974f
vadzim
committed
8a2974f
View commit details
Copy full SHA for 8a2974f
Browse repository at this point
fixup: fix variable name
vadzim
committed
8528ad4
View commit details
Copy full SHA for 8528ad4
Browse repository at this point
fixup: run callback with process.nextTick
vadzim
committed
e821b98
View commit details
Copy full SHA for e821b98
Browse repository at this point
remove unnesessary closure
vadzim
committed
e9becca
View commit details
Copy full SHA for e9becca
Browse repository at this point
fixup: do not doublecheck needToClose flag
vadzim
committed
509be2c
View commit details
Copy full SHA for 509be2c
Browse repository at this point
Commits on Apr 16, 2020
fixup: make _destroy not async
vadzim
committed
7aac752
View commit details
Copy full SHA for 7aac752
Browse repository at this point
Commits on Apr 17, 2020
fixup: trigger build
vadzim
committed
bffbf58
View commit details
Copy full SHA for bffbf58
Browse repository at this point
You can’t perform that action at this time.