net/streams: don't return the stream object from onStreamRead - #34375

Closed

robey wants to merge 10 commits into

nodejs:masterfrom

robey:onread-fix

Commits on Jul 24, 2020

streams: don't return the stream object from onStreamRead
robey
committed
0865a22
streams: fix 2nd instance
robey
committed
851667e
add a link to the bug, by request
robey
committed
f646c23
add a test that crashes without the fix.
robey
committed
eea77a5
fix linter error
robey
committed
98daa59
add extra check in stream_base.cc to be extra sure.
robey
committed
1440eae
undo "nice to have" which breaks some tests (sorry)
robey
committed
965c0b4
give up on asserting that everyone sees the same error
robey
committed
27bc342

Commits on Jul 30, 2020

make a guess about why new tests are failing
robey
committed
4663458

Commits on Jul 31, 2020

try removing the test completely
robey
committed
251a8c9