Skip to content

test: update wpt status for url - #35335

Closed
watilde wants to merge 1 commit into
nodejs:masterfrom
watilde:test/url
Closed

test: update wpt status for url#35335
watilde wants to merge 1 commit into
nodejs:masterfrom
watilde:test/url

Conversation

@watilde

@watilde watilde commented Sep 25, 2020

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@watilde watilde added test Issues and PRs related to Node.js core tests and test infrastructure. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Sep 25, 2020
@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@watilde

watilde commented Sep 28, 2020

Copy link
Copy Markdown
Member Author

The latest ci result seems to be green: https://ci.nodejs.org/job/node-test-pull-request/33264/

watilde added a commit that referenced this pull request Sep 28, 2020
PR-URL: #35335
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@watilde

watilde commented Sep 28, 2020

Copy link
Copy Markdown
Member Author

Landed in c88d845

@watilde watilde closed this Sep 28, 2020
@watilde
watilde deleted the test/url branch September 28, 2020 03:58
@watilde

watilde commented Sep 28, 2020

Copy link
Copy Markdown
Member Author

Put dont-land-on-v14.x because this patch is depending on #33770

joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
PR-URL: nodejs#35335
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to Node.js core tests and test infrastructure. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants