Skip to content

tools: rollback highlight.js - #41084

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-em-all
Closed

tools: rollback highlight.js#41084
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-em-all

Conversation

@Trott

@Trott Trott commented Dec 4, 2021

Copy link
Copy Markdown
Member

Same as #41078 but rebased to include the workaround for the issue with test-macos that is thus far preventing that fast-tracked PR from landing.

Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.
@Trott Trott added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Dec 4, 2021
@github-actions

github-actions Bot commented Dec 4, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 4, 2021
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. tools Issues and PRs related to the tools directory. labels Dec 4, 2021
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 4, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@targos

targos commented Dec 4, 2021

Copy link
Copy Markdown
Member

@richardlau

@aduh95

aduh95 commented Dec 4, 2021

Copy link
Copy Markdown
Contributor

#41078 has landed (see #41078 (comment)).

@aduh95 aduh95 closed this Dec 4, 2021
@Trott
Trott deleted the fix-em-all branch September 25, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants