Skip to content

meta: update AUTHORS - #41144

Merged
Trott merged 1 commit into
masterfrom
actions/authors-update
Dec 12, 2021
Merged

meta: update AUTHORS#41144
Trott merged 1 commit into
masterfrom
actions/authors-update

Conversation

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Here are some new additions to the AUTHORS file. This is an automatically generated PR by the authors.yml GitHub Action, which runs tools/update-authors.js.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Dec 12, 2021

@Trott Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tierney's entry is a duplicate that needs a .mailmap entry addition instead.

@Trott Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to land now.

@Trott Trott added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Dec 12, 2021
@Trott Trott added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Dec 12, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 12, 2021
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Dec 12, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author
Commit Queue failed
- Loading data for nodejs/node/pull/41144
✔  Done loading data for nodejs/node/pull/41144
----------------------------------- PR info ------------------------------------
Title      meta: update AUTHORS (#41144)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/authors-update -> nodejs:master
Labels     meta, fast-track, commit-queue-squash
Commits    2
 - meta: update AUTHORS
 - fixup! meta: update AUTHORS
Committers 2
 - Node.js GitHub Bot 
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/41144
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41144
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 12 Dec 2021 00:16:11 GMT
   ✔  Approvals: 2
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/41144#pullrequestreview-829579644
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41144#pullrequestreview-829660067
   ℹ  This PR is being fast-tracked
   ✖  GitHub CI is still running
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1570247089

PR-URL: #41144
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Trott force-pushed the actions/authors-update branch from 2df2823 to 4d7dd6c Compare December 12, 2021 23:49
@Trott

Trott commented Dec 12, 2021

Copy link
Copy Markdown
Member

Landed in 4d7dd6c

@Trott
Trott merged commit 4d7dd6c into master Dec 12, 2021
@Trott
Trott deleted the actions/authors-update branch December 12, 2021 23:50
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
PR-URL: #41144
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
PR-URL: #41144
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
PR-URL: #41144
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
PR-URL: #41144
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. commit-queue-squash PRs the Commit Queue should land as one squashed commit. fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants