Skip to content

tools: use Set instead of { [key]: true } object - #41675

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
tniessen:tools-doc-allhtml-seen-should-be-set
Jan 24, 2022
Merged

tools: use Set instead of { [key]: true } object#41675
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
tniessen:tools-doc-allhtml-seen-should-be-set

Conversation

@tniessen

@tniessen tniessen commented Jan 24, 2022

Copy link
Copy Markdown
Member

A Set has clearer semantics than an object whose values are always true.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. tools Issues and PRs related to the tools directory. labels Jan 24, 2022
@benjamingr benjamingr added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jan 24, 2022
@github-actions

github-actions Bot commented Jan 24, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @benjamingr. Please 👍 to approve.

@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 24, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 24, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 400b7c2 into nodejs:master Jan 24, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 24, 2022

Copy link
Copy Markdown
Collaborator

Landed in 400b7c2

BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@tniessen @BethGriggs
tools: use Set instead of { [key]: true } object
5fe7cfa 
PR-URL: #41675
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
tniessen added a commit to tniessen/node that referenced this pull request Jan 25, 2022
@tniessen
tools: use Set instead of { [key]: true } object
442217e 
Refs: nodejs#41675
@tniessen tniessen mentioned this pull request Jan 25, 2022
Merged
nodejs-github-bot pushed a commit that referenced this pull request Jan 28, 2022
@tniessen
tools: use Set instead of { [key]: true } object
334fb38 
Refs: #41675

PR-URL: #41695
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@tniessen @ruyadorno
tools: use Set instead of { [key]: true } object
3190e36 
Refs: #41675

PR-URL: #41695
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@tniessen @danielleadams
tools: use Set instead of { [key]: true } object
55341ee 
PR-URL: #41675
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@tniessen @danielleadams
tools: use Set instead of { [key]: true } object
799f850 
Refs: #41675

PR-URL: #41695
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@tniessen @danielleadams
tools: use Set instead of { [key]: true } object
543f168 
PR-URL: #41675
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@tniessen @danielleadams
tools: use Set instead of { [key]: true } object
3918467 
Refs: #41675

PR-URL: #41695
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@tniessen @danielleadams
tools: use Set instead of { [key]: true } object
1cbdc98 
PR-URL: #41675
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@tniessen @danielleadams
tools: use Set instead of { [key]: true } object
9d23a27 
Refs: #41675

PR-URL: #41695
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tniessen @nodejs-github-bot @benjamingr @targos @aduh95