benchmark: differentiate whatwg and legacy url - #47377
Merged
Merged
Conversation
nodejs-github-bot
added
benchmark
Member
Huh? That sounds like a good reason not to backport Ada to Node.js 18 if it's going to cause a regression. |
Member
Author
I mean Ada is faster than url.parse by 3x. Bad way to rephrase it, my bad! |
Member
Author
|
cc @nodejs/url @nodejs/performance appreciate reviews |
benjamingr
approved these changes
Apr 6, 2023
lemire
approved these changes
Apr 6, 2023
anonrig
added
the
author ready
TimothyGu
approved these changes
Apr 7, 2023
TimothyGu
left a comment
TimothyGu
left a comment
Member
There was a problem hiding this comment.
I'm ok with this as long as the results between the new legacy-only and whatwg-only benchmarks are still comparable – which they seem to be.
anonrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/47377 ✔ Done loading data for nodejs/node/pull/47377 ----------------------------------- PR info ------------------------------------ Title benchmark: differentiate whatwg and legacy url (#47377) Author Yagiz Nizipli (@anonrig) Branch anonrig:benchmark-urls -> nodejs:main Labels url, benchmark, author ready, commit-queue-squash Commits 2 - benchmark: differentiate whatwg and legacy url - fixup! benchmark: differentiate whatwg and legacy url Committers 1 - Yagiz Nizipli PR-URL: https://github.com/nodejs/node/pull/47377 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Tiancheng "Timothy" Gu ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47377 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Tiancheng "Timothy" Gu -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - fixup! benchmark: differentiate whatwg and legacy url ℹ This PR was created on Mon, 03 Apr 2023 02:09:09 GMT ✔ Approvals: 2 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/47377#pullrequestreview-1374972136 ✔ - Tiancheng "Timothy" Gu (@TimothyGu) (TSC): https://github.com/nodejs/node/pull/47377#pullrequestreview-1375735658 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4693909020 |
nodejs-github-bot
added
the
commit-queue-failed
Member
Author
|
@nodejs/performance can you review? |
KhafraDev
approved these changes
Apr 13, 2023
anonrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in cd0fcf2 |
targos
pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47377 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47377 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Member
|
depends on #47351 and #47179 |
targos
pushed a commit
that referenced
this pull request
Nov 10, 2023
PR-URL: #47377 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#47377 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#47377 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging Ada pull request, Ada will be 3x faster than the legacy
url.parsemethod, and we don't even need to run the legacy benchmarks most of the time. This pull request splits the benchmarks into multiple benchmarks.