Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
nodejs
/
node
Public
Uh oh!
There was an error while loading.
Please reload this page
.
Notifications
You must be signed in to change notification settings
Fork
37.3k
Star
122k
Code
Issues
623
Pull requests
554
Actions
Projects
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Projects
Security and quality
Insights
[v18.x] Revert "url: drop ICU requirement for parsing hostnames"
- #48869
#48869
Closed
aduh95
wants to merge 4 commits into
nodejs:v18.x-staging
nodejs/node:v18.x-staging
from
aduh95:revert-v18-breaking-change
aduh95/node:revert-v18-breaking-change
Copy head branch name to clipboard
Conversation
Commits
4
(4)
Checks
Files changed
Closed
[v18.x] Revert "url: drop ICU requirement for parsing hostnames"
#48869
aduh95
wants to merge 4 commits into
nodejs:v18.x-staging
nodejs/node:v18.x-staging
from
aduh95:revert-v18-breaking-change
aduh95/node:revert-v18-breaking-change
Copy head branch name to clipboard
Commits
Commits on Jul 21, 2023
Revert "url: drop ICU requirement for parsing hostnames"
Show description for 0560f54
aduh95
committed
0560f54
View commit details
Copy full SHA for 0560f54
Browse repository at this point
fixup! Revert "url: drop ICU requirement for parsing hostnames"
aduh95
committed
f3d70d4
View commit details
Copy full SHA for f3d70d4
Browse repository at this point
fixup! Revert "url: drop ICU requirement for parsing hostnames"
aduh95
committed
b3b5367
View commit details
Copy full SHA for b3b5367
Browse repository at this point
url: drop ICU requirement for parsing hostnames in `URL`
aduh95
committed
474979e
View commit details
Copy full SHA for 474979e
Browse repository at this point
You can’t perform that action at this time.
