Skip to content

stream: readable use bitmap accessors - #50350

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
nxtedition:readable-bitmap
Oct 25, 2023
Merged

stream: readable use bitmap accessors#50350
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
nxtedition:readable-bitmap

Conversation

@ronag

@ronag ronag commented Oct 23, 2023

Copy link
Copy Markdown
Member 
streams/pipe-object-mode.js n=5000000         **      8.12 %       ±5.09% ±7.09% ±9.94%
streams/pipe.js n=5000000                             1.64 %       ±2.67% ±3.69% ±5.10%

@nodejs-github-bot

nodejs-github-bot commented Oct 23, 2023 •
edited by ronag
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 23, 2023
@ronag
ronag requested review from mcollina and rluvaton October 23, 2023 21:04
@rluvaton rluvaton added stream Issues and PRs related to Node.js streams. performance Issues and PRs related to the performance of Node.js. needs-benchmark-ci PRs that need a benchmark CI run. labels Oct 23, 2023
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 23, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55165/

@ronag ronag changed the title stream: Readable use bitmap accessors stream: readable use bitmap accessors Oct 24, 2023
@ronag ronag added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55172/

@ronag ronag added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 24, 2023
Uzlopak
Uzlopak approved these changes Oct 24, 2023
View reviewed changes

@Uzlopak Uzlopak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55176/

@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55189/

@github-actions github-actions Bot mentioned this pull request Oct 25, 2023
Open
16 tasks
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/50350
✔  Done loading data for nodejs/node/pull/50350
----------------------------------- PR info ------------------------------------
Title      stream: readable use bitmap accessors (#50350)
Author     Robert Nagy  (@ronag)
Branch     ronag:readable-bitmap -> nodejs:main
Labels     stream, performance, author ready, needs-ci, needs-benchmark-ci
Commits    1
 - stream: readable use bitmap accessors
Committers 1
 - Robert Nagy 
PR-URL: https://github.com/nodejs/node/pull/50350
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Raz Luvaton 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50350
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Raz Luvaton 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - stream: readable use bitmap accessors
   ℹ  This PR was created on Mon, 23 Oct 2023 21:04:28 GMT
   ✔  Approvals: 2
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50350#pullrequestreview-1693524231
   ✔  - Raz Luvaton (@rluvaton): https://github.com/nodejs/node/pull/50350#pullrequestreview-1693525520
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-10-24T13:57:48Z: https://ci.nodejs.org/job/node-test-pull-request/55189/
- Querying data for job/node-test-pull-request/55189/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6646200515

@rluvaton rluvaton added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 25, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 31e0759 into nodejs:main Oct 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in 31e0759

This was referenced Oct 26, 2023
Open
Open
Open
targos pushed a commit that referenced this pull request Nov 11, 2023
@ronag @targos
stream: readable use bitmap accessors
586ec48 
PR-URL: #50350
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@ronag @UlisesGascon
stream: readable use bitmap accessors
9d52430 
PR-URL: #50350
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
@dead-claudia dead-claudia mentioned this pull request Feb 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@rluvaton rluvaton rluvaton approved these changes
@mcollina mcollina Awaiting requested review from mcollina
+1 more reviewer
@Uzlopak Uzlopak Uzlopak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-benchmark-ci PRs that need a benchmark CI run. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js. stream Issues and PRs related to Node.js streams.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ronag @nodejs-github-bot @benjamingr @Uzlopak @rluvaton