Skip to content

deps: update icu to - #50495

Closed
nodejs-github-bot wants to merge 1 commit into
mainfrom
actions/tools-update-icu
Closed

deps: update icu to#50495
nodejs-github-bot wants to merge 1 commit into
mainfrom
actions/tools-update-icu

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Nov 1, 2023

Copy link
Copy Markdown
Collaborator

This is an automated update of icu to .

@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. test Issues and PRs related to Node.js core tests and test infrastructure. needs-ci PRs that need a full CI run. labels Nov 1, 2023
@marco-ippolito

marco-ippolito commented Nov 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

update ICU to what? 😄 I guess it's a bug, also it's not updating the maintaining-dependencies list
@nodejs/security-wg

@marco-ippolito marco-ippolito mentioned this pull request Nov 1, 2023
Closed
@targos

targos commented Nov 1, 2023

Copy link
Copy Markdown
Member

https://github.com/nodejs/node/actions/runs/6717282091/job/18254870034

Comparing checksums: deposited  with 71e60b22697c4f35820a1897417dbab4
Skipped because checksums do not match.

The script should probably end with an error if there is a checksum problem.

@targos

targos commented Nov 1, 2023

Copy link
Copy Markdown
Member

I'd like to retry it.

@targos targos closed this Nov 1, 2023
@targos
targos deleted the actions/tools-update-icu branch November 1, 2023 08:47
targos added a commit to targos/node that referenced this pull request Nov 2, 2023
@targos
tools: compare ICU checksums before file changes
582ff30 
Otherwise we end up with an bad update PR when checksums don't match.

Refs: nodejs#50495
@targos targos mentioned this pull request Nov 2, 2023
Merged
nodejs-github-bot pushed a commit that referenced this pull request Nov 6, 2023
@targos
tools: compare ICU checksums before file changes
cde3296 
Otherwise we end up with an bad update PR when checksums don't match.

Refs: #50495
PR-URL: #50522
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Nov 11, 2023
@targos
tools: compare ICU checksums before file changes
c50b9b3 
Otherwise we end up with an bad update PR when checksums don't match.

Refs: #50495
PR-URL: #50522
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Nov 14, 2023
@targos
tools: compare ICU checksums before file changes
257e220 
Otherwise we end up with an bad update PR when checksums don't match.

Refs: #50495
PR-URL: #50522
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@targos @UlisesGascon
tools: compare ICU checksums before file changes
2fd78fc 
Otherwise we end up with an bad update PR when checksums don't match.

Refs: #50495
PR-URL: #50522
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@srl295

srl295 commented Jan 8, 2024

Copy link
Copy Markdown
Member

Why didn't it match? was the release broken or transient err?

@targos

targos commented Jan 8, 2024

Copy link
Copy Markdown
Member

It was #50498 (missing checksum files in the release artifacts)

@srl295

srl295 commented Jan 8, 2024

Copy link
Copy Markdown
Member

Thanks.

74.2 had a broken LICENSE file, not sure if that has been corrected.

@targos

targos commented Jan 8, 2024

Copy link
Copy Markdown
Member

The problem with 74.2 is that it's still a Pre-release on GitHub: https://github.com/unicode-org/icu/releases

@richardlau

richardlau commented Jan 8, 2024

Copy link
Copy Markdown
Member

The problem with 74.2 is that it's still a Pre-release on GitHub: https://github.com/unicode-org/icu/releases

FWIW I opened an issue for this last week: https://unicode-org.atlassian.net/browse/ICU-22622

@srl295

srl295 commented Jan 8, 2024

Copy link
Copy Markdown
Member

The problem with 74.2 is that it's still a Pre-release on GitHub: https://github.com/unicode-org/icu/releases

FWIW I opened an issue for this last week: https://unicode-org.atlassian.net/browse/ICU-22622

cross linked to another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nodejs-github-bot @marco-ippolito @targos @srl295 @richardlau