tools: add lint rule to keep primordials in ASCII order - #52592
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
Member
|
I wish we adopted |
anonrig
approved these changes
Apr 19, 2024
JakobJingleheimer
approved these changes
Apr 19, 2024
Member
Note that primordials are not imported. They are carried around by the function contexts in the internal modules (which are not ESM, either, but wrapped functions similar to CJS) |
aduh95
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
anonrig
reviewed
Apr 19, 2024
Collaborator
anonrig
approved these changes
Apr 20, 2024
Collaborator
This comment was marked as outdated.
This comment was marked as outdated.
aduh95
added
the
commit-queue
MoLow
approved these changes
Apr 21, 2024
nodejs-github-bot
removed
the
commit-queue
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/52592 ✔ Done loading data for nodejs/node/pull/52592 ----------------------------------- PR info ------------------------------------ Title tools: add lint rule to keep primordials in ASCII order (#52592) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:primordials-ascii-order -> nodejs:main Labels lib / src, author ready, needs-ci Commits 5 - tools: add lint rule to keep primordials in ASCII order - fixup! tools: add lint rule to keep primordials in ASCII order - enforce multiline - fixup! enforce multiline - fixup! enforce multiline Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/52592 Reviewed-By: Yagiz Nizipli Reviewed-By: Jacob Smith Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52592 Reviewed-By: Yagiz Nizipli Reviewed-By: Jacob Smith Reviewed-By: Moshe Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 19 Apr 2024 14:12:46 GMT ✔ Approvals: 3 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/52592#pullrequestreview-2013069800 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/52592#pullrequestreview-2011794306 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/52592#pullrequestreview-2013335800 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-04-20T10:58:00Z: https://ci.nodejs.org/job/node-test-pull-request/58543/ - Querying data for job/node-test-pull-request/58543/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 52592 From https://github.com/nodejs/node * branch refs/pull/52592/merge -> FETCH_HEAD ✔ Fetched commits as 461722d64cfd..a37d2682e6f6 -------------------------------------------------------------------------------- Auto-merging lib/internal/modules/esm/get_format.js [main 8c2d7fc8ad] tools: add lint rule to keep primordials in ASCII order Author: Antoine du Hamel Date: Fri Apr 19 16:06:52 2024 +0200 87 files changed, 281 insertions(+), 180 deletions(-) create mode 100644 test/parallel/test-eslint-alphabetize-primordials.js create mode 100644 tools/eslint-rules/alphabetize-primordials.js [main 85a6613c8b] fixup! tools: add lint rule to keep primordials in ASCII order Author: Antoine du Hamel Date: Fri Apr 19 16:14:58 2024 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main cbb4bf5260] enforce multiline Author: Antoine du Hamel Date: Fri Apr 19 17:27:10 2024 +0200 2 files changed, 23 insertions(+), 9 deletions(-) [main 7b4bc5cdc4] fixup! enforce multiline Author: Antoine du Hamel Date: Fri Apr 19 17:33:36 2024 +0200 10 files changed, 38 insertions(+), 10 deletions(-) [main 53e4c0aaee] fixup! enforce multiline Author: Antoine du Hamel Date: Fri Apr 19 18:39:23 2024 +0200 1 file changed, 7 insertions(+), 3 deletions(-) ✔ Patches applied There are 5 commits in the PR. Attempting autorebase. Rebasing (2/7) Rebasing (3/7)https://github.com/nodejs/node/actions/runs/8773332187 |
nodejs-github-bot
added
the
commit-queue-failed
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in a596af0 |
aduh95
added a commit
that referenced
this pull request
Apr 29, 2024
PR-URL: #52592 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the sake on consistency, reduce noise in PR reviews, and to minimize the chance of conflicts if two PR tries to introduce the same primordial.
Given the size of the change, we've done an OK job at keeping the ASCII order manually, however there's no reason to that work manually when our computer can do it better than us :)