Skip to content

test: refactor fs readdir buffer with test runner - #55748

Closed
sercanpaspal wants to merge 1 commit into
nodejs:mainfrom
sercanpaspal:test-refactor-fs-readdir-buffer-with-test-runner
Closed

test: refactor fs readdir buffer with test runner#55748
sercanpaspal wants to merge 1 commit into
nodejs:mainfrom
sercanpaspal:test-refactor-fs-readdir-buffer-with-test-runner

Conversation

@sercanpaspal

@sercanpaspal sercanpaspal commented Nov 6, 2024

Copy link
Copy Markdown

Refactor of test/parallel/test-fs-readdir-buffer.js with node test runner.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 6, 2024
@sercanpaspal
sercanpaspal force-pushed the test-refactor-fs-readdir-buffer-with-test-runner branch from a0d780f to 684e6b9 Compare November 6, 2024 15:21
@bengl bengl added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Nov 6, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 6, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@sercanpaspal
sercanpaspal force-pushed the test-refactor-fs-readdir-buffer-with-test-runner branch 2 times, most recently from ab09006 to 843bb2d Compare November 6, 2024 15:36
@pmarchini

Copy link
Copy Markdown
Member

Hey @sercanpaspal, js linting is failing.
You can fix it running make lint-js-fix

image

@sercanpaspal
sercanpaspal force-pushed the test-refactor-fs-readdir-buffer-with-test-runner branch from 843bb2d to 33c87c4 Compare November 6, 2024 15:48
@sercanpaspal

Copy link
Copy Markdown
Author

Hi @pmarchini , thank you for your help & information.

@codecov

codecov Bot commented Nov 6, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.91%. Comparing base (1aa7135) to head (33c87c4).
⚠️ Report is 4739 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55748      +/-   ##
==========================================
- Coverage   88.40%   87.91%   -0.49%     
==========================================
  Files         654      654              
  Lines      187747   187747              
  Branches    36127    35820     -307     
==========================================
- Hits       165972   165062     -910     
- Misses      15009    15888     +879     
- Partials     6766     6797      +31     

see 99 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

@github-actions github-actions Bot added the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label Jul 28, 2026
@avivkeller avivkeller closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants