contextify: tie lifetimes of context & sandbox - #5786
Closed
ofrobots wants to merge 1 commit into
Closed
Conversation
mscdex
added
c++
commented
Mar 18, 2016
Contributor
commented
Mar 18, 2016
Member
|
LGTM |
1 similar comment
commented
Mar 18, 2016
Contributor
|
LGTM |
commented
Mar 18, 2016
Contributor
Author
|
I want to avoid a deeper hole, specially that this is going to be a Friday release. If bugs in this code still remain, they are going to be gc (i.e. timing) related. I think it would be best to proceed with a revert (i.e. #5782) and allow in depth review on this PR. |
commented
Mar 18, 2016
|
+1 |
Contributor
There was a problem hiding this comment.
nit: other two locations where --expose-gc is used the comment is placed directly after the 'use strict';.
When the previous set of changes (bfff07b) it was possible to have the context get garbage collected while sandbox was still live. We need to tie the lifetime of the context to the lifetime of the sandbox. Fixes: nodejs#5768 PR-URL: nodejs#5786
commented
Mar 19, 2016
Contributor
|
LGTM |
1 similar comment
commented
Mar 19, 2016
Member
|
LGTM |
commented
Mar 19, 2016
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
Affected core subsystem(s)
contextify
Description of change
When the previous set of changes (bfff07b) it was possible to have the
context get garbage collected while sandbox was still live. We need to
tie the lifetime of the context to the lifetime of the sandbox.
Fixes: #5768
R=@bnoordhuis
/cc @evanlucas @cjihrig
Note that this is not trivially back-portable to 5.x.
SetPrivatedoesn't exist on 5.x, but I can create a new PR once this lands on master. This does continue to address the memory growth issue reported in #3113, but we should get this vetted before backporting.CI: https://ci.nodejs.org/job/node-test-pull-request/1960/