buffer: add fast api for isAscii & isUtf8#58058
Open
anonrig wants to merge 4 commits into
Open
Conversation
6bb4020 to
8432a57
Compare
Renegade334
reviewed
Apr 28, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58058 +/- ##
==========================================
- Coverage 90.17% 90.16% -0.02%
==========================================
Files 630 630
Lines 186473 186496 +23
Branches 36613 36614 +1
==========================================
+ Hits 168160 168162 +2
- Misses 11128 11132 +4
- Partials 7185 7202 +17
🚀 New features to boost your workflow:
|
ronag
approved these changes
Apr 28, 2025
2841143 to
ab8d328
Compare
Renegade334
reviewed
Apr 29, 2025
ab8d328 to
d7ffbed
Compare
d7ffbed to
54410b2
Compare
54410b2 to
7e84063
Compare
Member
Author
|
@jasnell @Renegade334 can you review this pull-request one more time? |
ronag
approved these changes
May 3, 2025
Collaborator
Renegade334
reviewed
May 3, 2025
jasnell
reviewed
May 7, 2025
jasnell
approved these changes
May 7, 2025
jasnell
approved these changes
May 7, 2025
Collaborator
juanarbol
approved these changes
May 7, 2025
Collaborator
Collaborator
H4ad
approved these changes
Jun 26, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Member
|
The failure in CI here is not a flaky failure. It's relevant to the change being made here. That should be fixed before trying CI again. |
Ethan-Arrowood
approved these changes
Jun 30, 2025
|
Looks like this was covered and released in #64169. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds v8 fast api for IsUtf8 and IsAscii methods
isAscii benchmark: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1706/
isUtf8 benchmark: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1708/