watch: remove NODE_OPTIONS from spawn call to prevent infinite loop - #61838
watch: remove NODE_OPTIONS from spawn call to prevent infinite loop#61838viiktordev wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61838 +/- ##
==========================================
- Coverage 89.72% 89.71% -0.01%
==========================================
Files 675 675
Lines 204797 204797
Branches 39344 39347 +3
==========================================
- Hits 183752 183740 -12
- Misses 13324 13335 +11
- Partials 7721 7722 +1 🚀 New features to boost your workflow:
|
MoLow
left a comment
There was a problem hiding this comment.
Altough this does fix the bug, it has a much wider affect, and it will prevent NODE_OPTIONS usage with --watch.
|
This pull request has been marked as stale due to 90 days of inactivity. |
|
This pull request has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 120 days). |
Fixes #61740
The loop occurs during the child process spawn in watch mode. I removed
NODE_OPTIONSfrom the environment before callingspawn(), and it solved the issue.I also confirmed that all other flags set in NODE_OPTIONS continue to work after the code update.