stream: fix ERR_INVALID_STATE when cancelling Readable.toWeb() by richardscarrott · Pull Request #62773 · nodejs/node

richardscarrott · 2026-04-16T10:18:36Z

When a web ReadableStream returned by Readable.toWeb() is cancelled while the underlying Readable is actively producing data, a pending onData callback can still fire after the controller has been closed and attempt to enqueue a chunk, throwing ERR_INVALID_STATE.

Check wasCanceled in the onData handler and return early to avoid calling controller.enqueue() on a closed controller.

Refs: #54205

codecov · 2026-04-16T20:18:15Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.13%. Comparing base (fd5b135) to head (93b1db6).
⚠️ Report is 370 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62773      +/-   ##
==========================================
+ Coverage   90.12%   90.13%   +0.01%     
==========================================
  Files         752      751       -1     
  Lines      252325   252639     +314     
  Branches    47456    47546      +90     
==========================================
+ Hits       227407   227724     +317     
+ Misses      16217    16197      -20     
- Partials     8701     8718      +17

Files with missing lines	Coverage Δ
lib/internal/webstreams/adapters.js	`86.62% <100.00%> (+0.01%)`	⬆️

... and 93 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

efekrskl · 2026-07-17T14:15:25Z

Thank you for your contribution @richardscarrott!

Could you please fix the linting errors?

smoores-dev · 2026-08-19T14:58:18Z

Howdy folks! I think we're running into this as well — @richardscarrott if you don't have time to take this over the finish line, happy to take it over and fix the linting errors!

richardscarrott · 2026-08-19T15:12:59Z

@smoores-dev @efekrskl soz, forgot about this. I have some time tomorrow to fix this up.

When a web ReadableStream returned by Readable.toWeb() is cancelled while the underlying Readable is actively producing data, a pending onData callback can still fire after the controller has been closed and attempt to enqueue a chunk, throwing ERR_INVALID_STATE. Check wasCanceled in the onData handler and return early to avoid calling controller.enqueue() on a closed controller. Refs: nodejs#54205

richardscarrott · 2026-08-23T10:24:04Z

Rebased onto main and fixed the lint error.

Worth flagging for re-review: #62394 rewrote newReadableStreamFromStreamReadable after this PR was opened, so the patch needed porting — the onData logic now lives in an inline 'data' listener. I confirmed the race is still present on current main; without the guard, test-stream-readable-to-web-termination.js fails with:

TypeError [ERR_INVALID_STATE]: Invalid state: Controller is already closed
    at ReadableStreamDefaultController.enqueue (node:internal/webstreams/readablestream:1189:13)
    at Readable.onData (node:internal/webstreams/adapters:547:18)
    at flow (node:internal/streams/readable:1319:53)
    at resume_ (node:internal/streams/readable:1295:3)

Note this is the enqueue path, distinct from the close path in #54205 (which #54206 already fixed) — hence Refs: rather than Fixes:. Upstream's rewritten test file is preserved as-is with the new case appended.

@meixg your approval predates the rebase, so this likely needs another look.

nodejs-github-bot · 2026-09-06T16:50:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/77096/

nodejs-github-bot · 2026-09-06T17:17:24Z

Commit Queue failed

   ✘    - github-actions: ACTION_REQUIRED
   ✘    - github-actions: ACTION_REQUIRED
   ✘    - github-actions: ACTION_REQUIRED
   ✘    - github-actions: ACTION_REQUIRED
   ✘    - github-actions: ACTION_REQUIRED
   ✘    - github-actions: ACTION_REQUIRED
   ✘    - github-actions: ACTION_REQUIRED
   ✘    - github-actions: ACTION_REQUIRED
   ✘    - github-actions: ACTION_REQUIRED
   ✘  Last Jenkins CI still running

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output

- Loading data for nodejs/node/pull/62773
✔  Done loading data for nodejs/node/pull/62773
----------------------------------- PR info ------------------------------------
Title      stream: fix ERR_INVALID_STATE when cancelling Readable.toWeb() (#62773)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     richardscarrott:fix/readable-to-web-cancel-race -> nodejs:main
Labels     author ready, needs-ci, commit-queue, web streams
Commits    1
 - stream: fix ERR_INVALID_STATE when cancelling Readable.toWeb()
Committers 1
 - Richard Scarrott <riscarrott@googlemail.com>
PR-URL: https://github.com/nodejs/node/pull/62773
Refs: https://github.com/nodejs/node/issues/54205
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62773
Refs: https://github.com/nodejs/node/issues/54205
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 16 Apr 2026 10:18:36 GMT
   ✔  Approvals: 1
   ✔  - Xuguang Mei (@meixg): https://github.com/nodejs/node/pull/62773#pullrequestreview-5125961513
   ✘  9 GitHub CI job(s) failed:
   ✘    - github-actions: ACTION_REQUIRED
   ✘    - github-actions: ACTION_REQUIRED
   ✘    - github-actions: ACTION_REQUIRED
   ✘    - github-actions: ACTION_REQUIRED
   ✘    - github-actions: ACTION_REQUIRED
   ✘    - github-actions: ACTION_REQUIRED
   ✘    - github-actions: ACTION_REQUIRED
   ✘    - github-actions: ACTION_REQUIRED
   ✘    - github-actions: ACTION_REQUIRED
   ℹ  Last Full PR CI on 2026-09-06T16:50:46Z: https://ci.nodejs.org/job/node-test-pull-request/77096/
- Querying data for job/node-test-pull-request/77096/
✔  Build data downloaded
   ✘  Last Jenkins CI still running
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

MikeMcC399

See Commit message guidelines according to the Pull requests documentation.

Your commit must contain the Signed-off-by line with your name and email address as an acknowledgement that you agree to the Developer Certificate of Origin.

This rule was introduced after this PR was originally submitted.

nodejs-github-bot added needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API. labels Apr 16, 2026

meixg approved these changes Apr 17, 2026

View reviewed changes

dushyant-hada-90 mentioned this pull request Jul 16, 2026

Readable.toWeb(): uncaughtException (ERR_INVALID_STATE "Controller is already closed") when the stream is canceled during backpressure resume #64529

Open

richardscarrott force-pushed the fix/readable-to-web-cancel-race branch from 96e546b to 93b1db6 Compare August 23, 2026 10:13

aqm857886159 mentioned this pull request Aug 24, 2026

ReadableStreamFrom: unguarded delayed controller.close() throws uncatchable ERR_INVALID_STATE when an async-iterable body is cancelled nodejs/undici#5715

Open

meixg approved these changes Sep 6, 2026

View reviewed changes

meixg added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Sep 6, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 6, 2026

meixg added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 6, 2026

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 6, 2026

MikeMcC399 reviewed Sep 6, 2026

View reviewed changes

Navigation Menu

Uh oh!

Uh oh!

stream: fix ERR_INVALID_STATE when cancelling Readable.toWeb() - #62773

stream: fix ERR_INVALID_STATE when cancelling Readable.toWeb()#62773
richardscarrott wants to merge 1 commit into
nodejs:mainfrom
richardscarrott:fix/readable-to-web-cancel-race

richardscarrott commented Apr 16, 2026

Uh oh!

codecov Bot commented Apr 16, 2026 •

edited

Loading

Uh oh!

efekrskl commented Jul 17, 2026 •

edited

Loading

Uh oh!

smoores-dev commented Aug 19, 2026

Uh oh!

richardscarrott commented Aug 19, 2026

Uh oh!

richardscarrott commented Aug 23, 2026

Uh oh!

nodejs-github-bot commented Sep 6, 2026

Uh oh!

nodejs-github-bot commented Sep 6, 2026

Uh oh!

MikeMcC399 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

richardscarrott commented Apr 16, 2026

Uh oh!

codecov Bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

efekrskl commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smoores-dev commented Aug 19, 2026

Uh oh!

richardscarrott commented Aug 19, 2026

Uh oh!

richardscarrott commented Aug 23, 2026

Uh oh!

nodejs-github-bot commented Sep 6, 2026

Uh oh!

nodejs-github-bot commented Sep 6, 2026

Commit Queue failed

Uh oh!

MikeMcC399 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Apr 16, 2026 •

edited

Loading

efekrskl commented Jul 17, 2026 •

edited

Loading