Skip to content

crypto: deduplicate X509 subject matching logic#63644

Open
tniessen wants to merge 1 commit into
nodejs:mainfrom
tniessen:x509-dedup-subject-match
Open

crypto: deduplicate X509 subject matching logic#63644
tniessen wants to merge 1 commit into
nodejs:mainfrom
tniessen:x509-dedup-subject-match

Conversation

@tniessen
Copy link
Copy Markdown
Member

CheckHost(), CheckEmail(), and CheckIP() all do very similar things. Extract the common logic into a helper function CheckX509Subject() to avoid duplication.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels May 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

❌ Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.30%. Comparing base (4639dcb) to head (2815b81).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/crypto/crypto_x509.cc 88.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #63644    +/-   ##
========================================
  Coverage   90.29%   90.30%            
========================================
  Files         730      730            
  Lines      234695   234795   +100     
  Branches    43956    43951     -5     
========================================
+ Hits       211927   212037   +110     
+ Misses      14494    14484    -10     
  Partials     8274     8274            
Files with missing lines Coverage Δ
src/crypto/crypto_x509.cc 73.63% <88.00%> (+1.18%) ⬆️

... and 61 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants