Skip to content

repl: add experimental TypeScript support#64077

Open
avivkeller wants to merge 4 commits into
nodejs:mainfrom
avivkeller:repl-ts
Open

repl: add experimental TypeScript support#64077
avivkeller wants to merge 4 commits into
nodejs:mainfrom
avivkeller:repl-ts

Conversation

@avivkeller

Copy link
Copy Markdown
Member

Adds experimental TypeScript support to the REPL, opt-in-able via the --experimental-repl-typescript flag.

@avivkeller avivkeller added repl Issues and PRs related to the REPL subsystem. experimental Issues and PRs related to experimental features. strip-types Issues or PRs related to strip-types support labels Jun 23, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config
  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 23, 2026
@avivkeller
avivkeller marked this pull request as draft June 23, 2026 00:45
@avivkeller avivkeller added the blocked PRs that are blocked by other issues or PRs. label Jun 23, 2026
Comment thread doc/api/cli.md Outdated
added: REPLACEME
-->

> Stability: 1.2 - Release candidate

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why release candidate

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The underlying transformer, https://nodejs.org/api/module.html#modulestriptypescripttypescode-options, is a release candidate, I figured this would be an extension of that

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has a larger scope than that api

Comment thread test/parallel/test-repl-typescript.js Outdated
assert.match(output.accumulator, /3\n> /);

// Transform TypeScript to JavaScript and evaluate it
input.emit('data', 'enum Color { Red, Green, Blue }\n');

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for:
const foo = () => 'hello world'; foo<Object>();
If should return false. This basically makes sure valid js is evaluated before ts

Comment thread lib/repl.js Outdated
@Renegade334

Copy link
Copy Markdown
Member

This is going to cause problems with multiline, I suspect.

Concise example:

const regexps = new Set<
  RegExp
>();

If typed as multiline input to REPL, it's going to consider the statement complete after the second newline, as it's a valid JS statement, and evaluate new Set < RegExp, which evaluates to true. I don't know that there's any way around these sorts of parsing conflicts.

@marco-ippolito

Copy link
Copy Markdown
Member

It should be handled exactly like we handle the -e and -p. If it's valid js treat it as such otherwise fallback on TS

@avivkeller
avivkeller marked this pull request as ready for review June 23, 2026 14:27
@avivkeller avivkeller removed the blocked PRs that are blocked by other issues or PRs. label Jun 23, 2026
Comment thread src/node_options.h Outdated
@avivkeller
avivkeller marked this pull request as draft June 28, 2026 18:02
Signed-off-by: Aviv Keller <me@aviv.sh>
@avivkeller
avivkeller marked this pull request as ready for review July 18, 2026 22:41
@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 68.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.14%. Comparing base (4f844f4) to head (86bc763).

Files with missing lines Patch % Lines
lib/internal/repl/eval.js 65.21% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #64077   +/-   ##
=======================================
  Coverage   90.13%   90.14%           
=======================================
  Files         741      741           
  Lines      241976   241998   +22     
  Branches    45543    45544    +1     
=======================================
+ Hits       218116   218140   +24     
+ Misses      15379    15378    -1     
+ Partials     8481     8480    -1     
Files with missing lines Coverage Δ
src/node_options.cc 76.72% <100.00%> (+0.02%) ⬆️
src/node_options.h 98.01% <100.00%> (+<0.01%) ⬆️
lib/internal/repl/eval.js 90.55% <65.21%> (-2.62%) ⬇️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. experimental Issues and PRs related to experimental features. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. strip-types Issues or PRs related to strip-types support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants