benchmark: trim down the argon2 sets#64218
Merged
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
benchmark
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva
force-pushed
the
trim-argon2-benchmark
branch
from
8b0ba48 to
4f013ea
Compare
lpinca
approved these changes
Jun 30, 2026
panva
added
the
author ready
anonrig
approved these changes
Jun 30, 2026
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 87a6aa6 |
richardlau
pushed a commit
that referenced
this pull request
Jul 3, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64218 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 8, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64218 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
nodejs-github-bot
added
the
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/64218 ✔ Done loading data for nodejs/node/pull/64218 ----------------------------------- PR info ------------------------------------ Title benchmark: trim down the argon2 sets (#64218) Author Filip Skokan <panva.ip@gmail.com> (@panva) Branch panva:trim-argon2-benchmark -> nodejs:main Labels crypto, benchmark, author ready Commits 1 - benchmark: trim down the argon2 sets Committers 1 - Filip Skokan <panva.ip@gmail.com> PR-URL: https://github.com/nodejs/node/pull/64218 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64218 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 30 Jun 2026 15:14:59 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/64218#pullrequestreview-4603490769 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/64218#pullrequestreview-4604579306 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/64218#pullrequestreview-4604673098 ⚠ This PR was merged on Thu, 02 Jul 2026 15:29:07 GMT ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/28952786250 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The argon2 benchmark needlessly runs for hours with the current parameters. This reduces the variants from 324 runs down to 12. The expensive knobs remain overridable with
--set.Realistically we can't influence the actual argon2 work so this should just benchmark the overhead.