Skip to content

doc: document net Socket server property#64364

Open
efekrskl wants to merge 1 commit into
nodejs:mainfrom
efekrskl:doc/socket-server-doc
Open

doc: document net Socket server property#64364
efekrskl wants to merge 1 commit into
nodejs:mainfrom
efekrskl:doc/socket-server-doc

Conversation

@efekrskl

@efekrskl efekrskl commented Jul 8, 2026

Copy link
Copy Markdown
Member

Closes #47148, based on the change proposed in #63458.

Original patch and investigation by @Herrtian

Based on the change proposed in nodejs#63458 by @Herrtian.

Signed-off-by: Efe Karasakal <hi@efe.dev>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Jul 8, 2026
@efekrskl

efekrskl commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

@Herrtian I revived your patch from #63458 so it wouldn't get lost, and credited you in the PR body. If you want, I can also add you as a co-author later, but I wanted to ask for your explicit approval for that first because we need to sign it off.

@pimterry pimterry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure what went wrong with the original PR process but thanks for picking this up @efekrskl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing reference (and types) for response.socket.server

3 participants