Skip to content

stream: remove custom CloneableDOMException implementation#64469

Open
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:clonable-domexception-who
Open

stream: remove custom CloneableDOMException implementation#64469
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:clonable-domexception-who

Conversation

@aduh95

@aduh95 aduh95 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

As the comment says, it's more than time to revisit the hack now that DOMException has been clonable for a while

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Jul 13, 2026
@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.23%. Comparing base (a1e3e6d) to head (dd6eea1).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/webstreams/transfer.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64469      +/-   ##
==========================================
- Coverage   90.24%   90.23%   -0.01%     
==========================================
  Files         741      741              
  Lines      241604   241521      -83     
  Branches    45526    45523       -3     
==========================================
- Hits       218029   217940      -89     
- Misses      15107    15114       +7     
+ Partials     8468     8467       -1     
Files with missing lines Coverage Δ
lib/internal/webstreams/transfer.js 96.52% <50.00%> (-1.57%) ⬇️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. web streams

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants