Skip to content

quic: fix coverage comment typo#64486

Open
sjungwon03 wants to merge 1 commit into
nodejs:mainfrom
sjungwon03:quic/fix-coverage-comment-typo
Open

quic: fix coverage comment typo#64486
sjungwon03 wants to merge 1 commit into
nodejs:mainfrom
sjungwon03:quic/fix-coverage-comment-typo

Conversation

@sjungwon03

Copy link
Copy Markdown
Contributor

Fix covreragecoverage in the TODO comments for the QUIC modules.

- // TODO(@jasnell) Temporarily ignoring c8 covrerage for this file while tests
+ // TODO(@jasnell) Temporarily ignoring c8 coverage for this file while tests

The same typo appears in diagnostics.js, quic.js, state.js, stats.js, and symbols.js.

Correct the coverage typo in TODO comments for QUIC modules.

Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 14, 2026
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.24%. Comparing base (ed63b19) to head (732f5c1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64486      +/-   ##
==========================================
- Coverage   92.01%   90.24%   -1.78%     
==========================================
  Files         381      741     +360     
  Lines      170167   241688   +71521     
  Branches    26075    45550   +19475     
==========================================
+ Hits       156585   218119   +61534     
- Misses      13291    15110    +1819     
- Partials      291     8459    +8168     
Files with missing lines Coverage Δ
lib/internal/quic/diagnostics.js 100.00% <100.00%> (ø)
lib/internal/quic/quic.js 100.00% <100.00%> (ø)
lib/internal/quic/state.js 100.00% <100.00%> (ø)
lib/internal/quic/stats.js 100.00% <100.00%> (ø)
lib/internal/quic/symbols.js 100.00% <100.00%> (ø)

... and 486 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants