child_process: keep SIGWINCH from killing on Win#64510
Open
PickBas wants to merge 1 commit into
Open
Conversation
Fixes: nodejs#64324 Signed-off-by: PickBas <sayed.kirill@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64510 +/- ##
==========================================
- Coverage 90.25% 90.24% -0.02%
==========================================
Files 741 739 -2
Lines 241216 241669 +453
Branches 45442 45548 +106
==========================================
+ Hits 217713 218093 +380
- Misses 15079 15110 +31
- Partials 8424 8466 +42
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
child_process: keep SIGWINCH from killing on Win
On Windows,
ProcessWrap::Killcoerced any signal outside{SIGKILL, SIGTERM, SIGINT, SIGQUIT, 0}toSIGKILL. This wrongly terminated a process onkill('SIGWINCH'), a non-terminal signal.SIGWINCHnow skips the coercion and reaches libuv, which returnsUV_ENOSYS, surfaced as anENOSYSerror in JS, leaving the target process alive.Fixes: #64324