Skip to content

lib: use assignFunctionName util where it makes sense#64515

Open
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:assignFunctionName
Open

lib: use assignFunctionName util where it makes sense#64515
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:assignFunctionName

Conversation

@aduh95

@aduh95 aduh95 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

To simplify the code

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added dns Issues and PRs related to the dns subsystem. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Jul 15, 2026
@pimterry pimterry added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.24%. Comparing base (bf5c221) to head (8b87b5e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #64515   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files         739      739           
  Lines      241653   241648    -5     
  Branches    45538    45544    +6     
=======================================
+ Hits       218073   218080    +7     
- Misses      15105    15109    +4     
+ Partials     8475     8459   -16     
Files with missing lines Coverage Δ
lib/internal/dns/callback_resolver.js 99.11% <100.00%> (-0.01%) ⬇️
lib/internal/util/inspector.js 100.00% <100.00%> (ø)

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. dns Issues and PRs related to the dns subsystem. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants