test: keep finalization before-exit ref alive#64521
Open
pimterry wants to merge 1 commit into
Open
Conversation
Signed-off-by: Tim Perry <pimterry@gmail.com>
Collaborator
trivikr
approved these changes
Jul 15, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64521 +/- ##
=======================================
Coverage 90.24% 90.24%
=======================================
Files 739 739
Lines 241653 241639 -14
Branches 45539 45544 +5
=======================================
+ Hits 218073 218076 +3
+ Misses 15111 15109 -2
+ Partials 8469 8454 -15 🚀 New features to boost your workflow:
|
bjohansebas
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fixture within the
test-process-finalizationtest, which flaked yesterday, and quite a bit recently: https://github.com/nodejs/reliability/issues?q=%22test-process-finalization%22. All the examples for the recent failures are from this fixture.Exactly the same problem & fix as for the sibling
test/fixtures/process/close.mjsfixture: #64085. I have checked and AFAICT this is the last remaining example of the set, so hopefully this'll make test-process-finalization stable once and for all 🤞