Skip to content

test: keep finalization before-exit ref alive#64521

Open
pimterry wants to merge 1 commit into
nodejs:mainfrom
pimterry:fix-proc-finalization-flake
Open

test: keep finalization before-exit ref alive#64521
pimterry wants to merge 1 commit into
nodejs:mainfrom
pimterry:fix-proc-finalization-flake

Conversation

@pimterry

Copy link
Copy Markdown
Member

This is a fixture within the test-process-finalization test, which flaked yesterday, and quite a bit recently: https://github.com/nodejs/reliability/issues?q=%22test-process-finalization%22. All the examples for the recent failures are from this fixture.

Exactly the same problem & fix as for the sibling test/fixtures/process/close.mjs fixture: #64085. I have checked and AFAICT this is the last remaining example of the set, so hopefully this'll make test-process-finalization stable once and for all 🤞

Signed-off-by: Tim Perry <pimterry@gmail.com>
@pimterry pimterry requested a review from trivikr July 15, 2026 16:11
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 15, 2026
@pimterry pimterry added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jul 15, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 15, 2026
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.24%. Comparing base (824bc66) to head (e5bbbdd).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #64521   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files         739      739           
  Lines      241653   241639   -14     
  Branches    45539    45544    +5     
=======================================
+ Hits       218073   218076    +3     
+ Misses      15111    15109    -2     
+ Partials     8469     8454   -15     

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants