Skip to content

test: fix flaky http2 socket proxy destroy test #64673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pimterry wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

test: fix flaky http2 socket proxy destroy test #64673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/parallel/test-http2-socket-proxy-destroy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');
const Countdown = require('../common/countdown');

// Calling .destroy() on the socket proxy must not throw
// (previously threw ERR_HTTP2_NO_SOCKET_MANIPULATION) and must
Expand All @@ -17,6 +18,8 @@ server.on('stream', common.mustCall(function(stream) {
stream.end('ok');
}, 2));

const countdown = new Countdown(2, () => server.close());

server.listen(0, common.mustCall(() => {
const port = server.address().port;

Expand All @@ -33,6 +36,7 @@ server.listen(0, common.mustCall(() => {
assert.strictEqual(client.socket, undefined);
// Destroying again through a stale proxy reference must not throw.
socket.destroy();
countdown.dec();
}));
}));
client.on('error', common.mustNotCall());
Expand All @@ -51,7 +55,7 @@ server.listen(0, common.mustCall(() => {
assert.strictEqual(err.message, 'boom');
}));
client.on('close', common.mustCall(() => {
server.close();
countdown.dec();
}));
}
}));
Loading