typings: wire up quic internal binding types - #65556
Merged
nodejs-github-bot merged 1 commit intoSep 21, 2026
Merged
Conversation
nodejs-github-bot
added
the
typings
typings/internalBinding/quic.d.ts already declares QuicBinding, but
it was never imported into globals.d.ts or added to
InternalBindingMap, so internalBinding('quic') resolved to `any`
instead of it.
Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com>
agape1225
force-pushed
the
typings-wire-up-quic-binding
branch
from
September 12, 2026 05:08
1c093ff to
a77966e
Compare
jasnell
approved these changes
Sep 19, 2026
daeyeon
added
author ready
Collaborator
|
Landed in 35f72de |
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Sep 27, 2026
typings/internalBinding/quic.d.ts already declares QuicBinding, but
it was never imported into globals.d.ts or added to
InternalBindingMap, so internalBinding('quic') resolved to `any`
instead of it.
Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com>
PR-URL: #65556
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typings/internalBinding/quic.d.ts already declares QuicBinding, but it was never imported into globals.d.ts or added to InternalBindingMap, so internalBinding('quic') resolved to
anyinstead of it.